-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all webui dependencies and refactor breaking changes #6327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschiffer
added
c/console
This is related to the Console
security
This is important for security
dependencies
Pull requests that update a dependency file
ui/web
This is related to a web interface
tooling
Development tooling
labels
Jun 14, 2023
github-actions
bot
removed
tooling
Development tooling
security
This is important for security
c/console
This is related to the Console
labels
Jun 14, 2023
kschiffer
force-pushed
the
fix/webui-dependency-updates
branch
from
June 29, 2023 15:22
e91742e
to
7454ed9
Compare
kschiffer
force-pushed
the
fix/webui-dependency-updates
branch
from
June 30, 2023 13:25
7454ed9
to
6a3105a
Compare
kschiffer
force-pushed
the
fix/webui-dependency-updates
branch
2 times, most recently
from
July 2, 2023 17:41
46570d4
to
1aa6f60
Compare
kschiffer
requested review from
ryaplots,
mjamescompton and
adriansmares
as code owners
July 2, 2023 17:41
kschiffer
force-pushed
the
fix/webui-dependency-updates
branch
2 times, most recently
from
July 3, 2023 09:50
826cba1
to
e2c296b
Compare
Here's a more detailed breakdown of what has been done in this PR:
All in all the refactor became quite huge because there were so many components affected by the router update, but functionally there are no changes and the end-to-end test run through, so I think we can trust this quite a bit but I would still suggest scanning the diff to get a gist of what these refactors are about. |
kschiffer
force-pushed
the
fix/webui-dependency-updates
branch
2 times, most recently
from
July 3, 2023 12:08
4f37a5d
to
fce6bc2
Compare
ryaplots
requested changes
Jul 3, 2023
kschiffer
force-pushed
the
fix/webui-dependency-updates
branch
from
July 3, 2023 16:04
68580f4
to
3e44f75
Compare
kschiffer
force-pushed
the
fix/webui-dependency-updates
branch
from
July 3, 2023 16:22
3e44f75
to
3fb25c1
Compare
ryaplots
approved these changes
Jul 4, 2023
adriansmares
approved these changes
Jul 4, 2023
This was referenced Jul 5, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
tooling
Development tooling
ui/web
This is related to a web interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates (almost) all javascript dependencies to the latest version applies many refactors to fix breaking changes.
Changes
react-leaflet
react-router
v6yup
connected-react-router
connect()
,withRequest()
,withFeatureRequirement()
,withBreadcrumbs()
) and replacing them with respective hooks.Testing
Tested a lot manually and end-to-end tests are passing.
Notes for Reviewers
Please see the detailed account in my comment below.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.